From 1a8090d5b906a52fff82559650ecbdbc000304e9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kasper=20Isager=20Dalsgar=C3=B0?= Date: Fri, 26 Jan 2024 13:40:16 +0100 Subject: [PATCH] Don't attempt to pass GCC-style flags to MSVC --- CMakeLists.txt | 24 +++++++++++++----------- vendor/libsodium.gyp | 19 ++++++++++--------- 2 files changed, 23 insertions(+), 20 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index cccd59c5..b101b327 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -212,17 +212,19 @@ target_include_directories( vendor/libsodium/src/libsodium/include/sodium ) -target_compile_options( - sodium - PRIVATE - -fvisibility=hidden - -fno-strict-aliasing - -fwrapv - -flax-vector-conversions - -Wno-unused-function - -Wno-unknown-pragmas - -Wno-unused-but-set-variable -) +if(NOT target MATCHES "win32") + target_compile_options( + sodium + PRIVATE + -fvisibility=hidden + -fno-strict-aliasing + -fwrapv + -flax-vector-conversions + -Wno-unused-function + -Wno-unknown-pragmas + -Wno-unused-but-set-variable + ) +endif() target_compile_definitions( sodium diff --git a/vendor/libsodium.gyp b/vendor/libsodium.gyp index 11ea1380..b0b85928 100644 --- a/vendor/libsodium.gyp +++ b/vendor/libsodium.gyp @@ -32,15 +32,6 @@ '-Wno-unused-but-set-variable', ], }, - 'cflags': [ - '-fvisibility=hidden', - '-fno-strict-aliasing', - '-fwrapv', - '-flax-vector-conversions', - '-Wno-unused-function', - '-Wno-unknown-pragmas', - '-Wno-unused-but-set-variable', - ], 'sources': [ './libsodium/src/libsodium/crypto_aead/aes256gcm/aesni/aead_aes256gcm_aesni.c', './libsodium/src/libsodium/crypto_aead/chacha20poly1305/sodium/aead_chacha20poly1305.c', @@ -219,6 +210,16 @@ 'HAVE_RAISE=1', 'HAVE_SYS_PARAM_H=1', ], + }, { + 'cflags': [ + '-fvisibility=hidden', + '-fno-strict-aliasing', + '-fwrapv', + '-flax-vector-conversions', + '-Wno-unused-function', + '-Wno-unknown-pragmas', + '-Wno-unused-but-set-variable', + ], }], ['target_arch=="x64"', { 'defines': [