Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glmnet.lasso_maxCoef() is missing a lambda argument? [bug] #31

Open
ptaitAtMcMaster opened this issue Aug 24, 2023 · 0 comments
Open

glmnet.lasso_maxCoef() is missing a lambda argument? [bug] #31

ptaitAtMcMaster opened this issue Aug 24, 2023 · 0 comments

Comments

@ptaitAtMcMaster
Copy link

Hi,
before I get into this issue report, I wanted to thank you for writing such a useful package :)

I have been using stabsel() with glmnet() and noticed the following on line 126 of glmnet.lasso_maxCoef:
fit <- glmnet::glmnet(x, y, ...)

glmnet.lasso_maxCoef() does not seem to be using the penalty parameter lambda= that is passed to it.

I was expecting line 126 to look like:

fit <- glmnet::glmnet(x, y, lambda=lambda, ...)

Assuming the lambda value passes the check on line 120, is it being captured by the ...? If not this looks like a bug.

Thanks
Peter

PS: ?glmnet suggests using predict.glmet() for single lambda values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant