Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .node-version to bin Node dev to v20 #828

Closed
wants to merge 3 commits into from
Closed

Add .node-version to bin Node dev to v20 #828

wants to merge 3 commits into from

Conversation

manzt
Copy link
Member

@manzt manzt commented Oct 2, 2024

The gl development dependency is a real pain. It only ships pre-built binaries for a couple of platforms and a very small semver range of NodeJS.

Ideally we'd be able to eliminate it entirely from out test suite (using an actual browser test, instead of the awkward electron/node thing we have right now).

This PR adds a .node-version file to the project, which will be respected by both our CI and fmn/nvm Node version managers. This should help with installations of gl in the future for folks wanting to contribute.

@manzt
Copy link
Member Author

manzt commented Oct 2, 2024

@ilan-gold , ok so the gl dependency isn't even needed? I'm going to open a separate PR.

@manzt manzt closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant