-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Max scale to Emoji's/Stickers #122
Comments
Also is there any way we could increase the resolution of emojis? |
Thanks for your feature request. I released version The resolution of the emojis depends on your device, in which quality they are available when you use the system default emojis. For the case you want to use emojis in high resolution will I recommend you to use a custom font. An example can you checkout here where I apply |
I overlooked that, emojis with this solution look much better. However in the example, opening emoji picker on iOS makes the app unresponsive for 3-5 seconds, could you check? If you'd like i could create a separate issue for this. |
Does it happen in the debug mode or also in the release mode? For the case it's in release mode too, can you test if it also freezes when you just open the emoji_picker in a bottom sheet without the image editor? That will help that we know the performance impact is from the pro_image_editor package or directly from the emoji_picker_flutter package. |
Tested emoji picker & seems like its that package's bug. Created an issue there, but it probably won't get addressed any time soon: Fintasys/emoji_picker_flutter#205. Doesn't matter if it's profile/debug, at least on iOS as I've retested on physical device & simulator. |
Okay, good idea that you create a new issue directly in the But to be honest, I think it will be a big challenge for the package owner to solve this problem. I also saw before on some platforms is a small performance impact when we scroll the emoji. The good thing is that the package owner built the project in such a way that we can edit it very detailed, which helped me to make it a bit better than the original way. The point is I go deep in this package and know a bit now how it works and as you can see here in the end, it's a normal text widget which renders the emoji. So I think we have now only the following options:
|
Thanks for the detailed answer. I guess I'll just keep the scale you've implemented for now in that case. |
Platforms
Android, iOS
Description
Add max scale to: StickerEditorConfigs & EmojiEditorConfigs.
Why
Would be nice to be able pass an argument to set the max scales for both of those layers. That way we could eliminate scenarios where the set layer is scaled so much it becomes blurry or pixelated.
The text was updated successfully, but these errors were encountered: