Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-observer http server logging improvements #2158

Closed
zone117x opened this issue Nov 6, 2024 · 0 comments · Fixed by #2160
Closed

Event-observer http server logging improvements #2158

zone117x opened this issue Nov 6, 2024 · 0 comments · Fixed by #2160

Comments

@zone117x
Copy link
Member

zone117x commented Nov 6, 2024

The fastify http event server used for observing events from stacks-core needs improved logging. Some logs we had when using Express also no longer show up.

Request completed log

The "request completed" log line isn't very useful by itself. It includes a randomly generated requestID that must be matched against a previous log entry to get the useful details url, request body size, etc.

Example of existing log line:

{"level":"info","time":"2024-10-23T10:24:32.995Z","pid":1,"hostname":"604488d07dce","name":"stacks-node-event","reqId":"req-i3","res":{"statusCode":200},"responseTime":4.694499969482422,"msg":"request completed"}

Unexpected connection termination logging

Log an error/warning when the stacks-node submits an http request and then terminates the http connection before we have replied. Currently there aren't useful logs for when this happens.

@github-project-automation github-project-automation bot moved this to 🆕 New in API Board Nov 6, 2024
@zone117x zone117x moved this from 🆕 New to 👀 In Review in API Board Nov 11, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in API Board Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant