Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfers per Block returns less results than limit #355

Open
forgxyz opened this issue May 8, 2024 · 1 comment
Open

Transfers per Block returns less results than limit #355

forgxyz opened this issue May 8, 2024 · 1 comment
Assignees

Comments

@forgxyz
Copy link

forgxyz commented May 8, 2024

Cross-posting from Discord

I have an issue that is causing reliability issues with our backfill and will create issues if we use this for prod to keep up with chainhead data. There are some blocks that do not return a full page with a request. E.g. block 840480. Response total indicates 67. Sending a request with offset 0 and limit 60 returns 56. Page 2 (offet 60/limit 60) returns 7 for a total of 63.

Now, if I send offset 56 (& limit 60) I get 11, for a grand total of 67 which is expected. However, not getting a full page (results=limit) is an issue

curl -L 'https://api.hiro.so/ordinals/v1/inscriptions/transfers?block=840480&offset=0&limit=60' \
-H 'Accept: application/json' > temp/840480.json

Block 839852 offset 360 looks to be the worst offender with just 29/60 (total = 1361)

import requests
len(requests.get('https://api.hiro.so/ordinals/v1/inscriptions/transfers?block=839852&offset=360&limit=60').json()['results'])

@WHYTEWYLL @sam-xyz

@lgalabru
Copy link

Thanks for the feedback @forgxyz! I'm moving this issue to the ordinals-api for better tracking.

@lgalabru lgalabru transferred this issue from hirosystems/ordhook May 10, 2024
@rafaelcr rafaelcr moved this from 🆕 New to 🏗 In Progress in Ordinals May 28, 2024
@smcclellan smcclellan moved this from 🏗 In Progress to 👀 In Review in Ordinals Jun 12, 2024
@smcclellan smcclellan moved this from 👀 In Review to 📋 Backlog in Ordinals Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants