Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stacks-explorer link should be devnet explorer #1539

Open
tippenein opened this issue Aug 8, 2024 · 10 comments
Open

stacks-explorer link should be devnet explorer #1539

tippenein opened this issue Aug 8, 2024 · 10 comments
Labels
good first issue Good for newcomers

Comments

@tippenein
Copy link
Collaborator

When running clarinet devnet start the link for the stacks-explorer should go to devnet, not mainnet.

The correct url is http://localhost:8000/?chain=testnet&api=http://localhost:3999

The work to fix this has been mostly done here but currently that branch will stall on "preparing container".

This issue is to get that status update to reflect a correct link

@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Aug 8, 2024
@tippenein tippenein added the good first issue Good for newcomers label Aug 8, 2024
@smcclellan smcclellan moved this from 🆕 New to 📋 Backlog in DevTools Aug 12, 2024
@binadamu-isiyoonekana
Copy link

binadamu-isiyoonekana commented Nov 12, 2024

Hi all.
If you don't mind, as a newbie, I'm willing to fix this issue.
Thanks

Image

@hugocaillard
Copy link
Collaborator

Hello @binadamu-isiyoonekana
My concern on this one is that the url will get troncated, but maybe that's not really an issue
If you're willibng to give it a try, that be nice! I just hope it won't be too ugly

@binadamu-isiyoonekana
Copy link

Two comments here:

  1. You're right, the URL is a bit ugly (see below). Why not just just indicating that it's truncated with ellipsis, like "http://localhost:8000/?chain=devnet ..."

Image

  1. By the way, it should be chain=devnet rather than chain=testnet. Correct?

Thanks

@hugocaillard
Copy link
Collaborator

@binadamu-isiyoonekana

  1. I don't think you can do that in the terminal UI
  2. devnet technically is a testnet, so I think that's fine

@binadamu-isiyoonekana
Copy link

Let me propose a PR tomorrow.

@hugocaillard
Copy link
Collaborator

@binadamu-isiyoonekana Sounds good. I can do a pass on the "good first issue" and make see if I can find others as well

@binadamu-isiyoonekana
Copy link

binadamu-isiyoonekana commented Nov 13, 2024

@binadamu-isiyoonekana

  1. I don't think you can do that in the terminal UI
  2. devnet technically is a testnet, so I think that's fine

@hugocaillard

Hey Hugo. Isn't it a bit ambiguous to mention testnet when devnet is in fact selected? Wouldn't it be clearer to display devnetinstead (though I understand that devnet and testnet are both testing platforms; however devnet is local while testnet networks are not)?

Image

@binadamu-isiyoonekana
Copy link

Hello @binadamu-isiyoonekana My concern on this one is that the url will get truncated, but maybe that's not really an issue If you're willibng to give it a try, that be nice! I just hope it won't be too ugly

In fact when the URL is truncated after resizing the terminal's window, the latter can become malformed (becoming, for instance, 'http://loca') and you cannot click on it for opening a browser. Do you consider the URL as informational only or would like the latter to be a clickable hyperlink as well (probably yes)?

@hugocaillard
Copy link
Collaborator

@binadamu-isiyoonekana It has to clickable.
So yes, if the URL is too long, it has a higher chance of getting truncated.
Regarding your other question, this is something we should discuss with the Explorer team

@binadamu-isiyoonekana
Copy link

@binadamu-isiyoonekana It has to clickable. So yes, if the URL is too long, it has a higher chance of getting truncated. Regarding your other question, this is something we should discuss with the Explorer team

@hugocaillard I'm currently evaluating a solution with ratatui where the text overflow will be "truncated" at the given size with ellipsis and the text to slide to the left when mouse is hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants