Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hardcode NodeJS backend port in frontend #14

Open
JohannesOehm opened this issue Dec 1, 2021 · 0 comments
Open

Do not hardcode NodeJS backend port in frontend #14

JohannesOehm opened this issue Dec 1, 2021 · 0 comments

Comments

@JohannesOehm
Copy link

In src/public/hooks:socket.js:6 the port of the NodeJS-backend is hardcoded to 3231. Please make this function more intelligent, so that it discovers which port is actually used to serve the frontend static pages or omits the port from the socketUrl string if port 80 is used with http or 443 is used with SSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant