You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Hifi monorepo, all the interface function implementations use the "override" modifier. The issue here is that the "override" modifier has been made optional for interface functions since Solidity v0.8.8, and so any implementations that are defined without it would still result in successful compilation.
In the Hifi monorepo, all the interface function implementations use the "override" modifier. The issue here is that the "override" modifier has been made optional for interface functions since Solidity v0.8.8, and so any implementations that are defined without it would still result in successful compilation.
I think we should not just stick to our current coding style throughout the entire monorepo, but we should also enforce it by enabling the "comprehensive-interface" solhint rule.
The text was updated successfully, but these errors were encountered: