Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solhint rule to enforce that all interface function implementations should be "override" #89

Open
scorpion9979 opened this issue Apr 18, 2022 · 0 comments

Comments

@scorpion9979
Copy link
Contributor

In the Hifi monorepo, all the interface function implementations use the "override" modifier. The issue here is that the "override" modifier has been made optional for interface functions since Solidity v0.8.8, and so any implementations that are defined without it would still result in successful compilation.

I think we should not just stick to our current coding style throughout the entire monorepo, but we should also enforce it by enabling the "comprehensive-interface" solhint rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant