Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style for text (especially headlines) is broken when having a single markdown as a page #8

Open
11 tasks
hendrikebbers opened this issue Oct 2, 2024 · 2 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. help wanted Extra attention is needed

Comments

@hendrikebbers
Copy link
Contributor

hendrikebbers commented Oct 2, 2024

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hiero or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hiero.

👾 Description of the issue

Currently headlines (h1, h2,....) are not rendered correctly for some pages.
An example of the problem can be found here.
The markdown for that page can be found here.
As you can see, the markdown uses headlines that are not styled like headlines in the rendered HTML view.

Bildschirmfoto 2024-10-02 um 13 35 37

For the single layout that is used for the page in hugo can be found here.

To fix this issue headlines (h1,h2, ...) should be rendered in a different style as it is done on the landingpage.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hiero developer community for support.
  • Wait for reviews: Members of the Hiero developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hiero community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@hendrikebbers hendrikebbers added good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. help wanted Extra attention is needed labels Oct 2, 2024
@SGCODEX
Copy link

SGCODEX commented Oct 2, 2024

Hi can you please assign this issue to me?

@SGCODEX
Copy link

SGCODEX commented Oct 2, 2024

Also sir, I wanted to ask...Over here we have to convert the code from markdown to HTML right to fix headline issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants