Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer is not always on bottom of page #3

Open
11 tasks
hendrikebbers opened this issue Oct 1, 2024 · 6 comments
Open
11 tasks

Footer is not always on bottom of page #3

hendrikebbers opened this issue Oct 1, 2024 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. help wanted Extra attention is needed

Comments

@hendrikebbers
Copy link
Contributor

hendrikebbers commented Oct 1, 2024

🆕🐥 First Timers Only

This issue is reserved for people who have never contributed to Hiero or any open source project in general.
We know that creating a pull request (PR) is a major barrier for new contributors.
The goal of this issue and all other issues labeled by 'Good First Issue' is to help you make your first contribution to Hiero.

👾 Description of the issue

If you have a page with not much content the footer of the page is not always on the bottom of the page:
Bildschirmfoto 2024-10-01 um 14 55 08

The given behavior can easily be recreated by adding a page (markdown) to content that defines simple as layout:

---
title: "Title of page"
layout: "simple"
---
content of the page

The footer is added directly in baseof.html.

📋 Step by step guide to do a contribution

If you have never contributed to an open source project at GitHub, the following step-by-step guide will introduce you to the workflow. More information and concrete samples for shell commands for each step can be found in our CONTRIBUTING.md file.
A more detailed general documentation of the GitHub PR workflow can be found here.

  • Claim this issue: Comment below that you are interested in working on the issue
  • Wait for assignment: A community member with the given rights will add you as an assignee of the issue
  • Fork the repository: You can do that in GitHub (by simply clicking the 'fork' button).
  • Check out the forked repository
  • Create a feature branch for the issue. We do not have a hard naming definition for branches but it is best practice to prefix the branch name with the issue id.
  • Solve the issue in your branch.
  • Commit your changes: Here, it is needed to add sign-off information to the commit to accept the "Developer Certificate of Origin" (https://developercertificate.org). More details can be found in our CONTRIBUTING.md
  • Start a Pull Request (PR): We have a pattern for naming pull requests that a GitHub Action checks. We use that pattern to support the creation of automatic release notes.
  • Check GitHub Actions: Several GitHub Actions will be triggered automatically for each PR. If a GitHub Action fails and you do not understand the cause of that error do not hesitate to add a comment to the PR and ask the Hiero developer community for support.
  • Wait for reviews: Members of the Hiero developer community will review your PR. If a reviewer finds any missing pieces or a problem, he or she will start a discussion with you and describe the next steps for solving the problem.
  • You did it 🎉: We will merge the fix in the develop branch. Thanks for being part of the Hiero community as an open-source contributor ❤️

🎉 Contribute to Hacktoberfest

Solve this issue as part of the Hacktoberfest event and get a chance to receive cool goodies like a T-Shirt. 🎽

🤔 Additional Information

If you have any questions, just ask us directly in this issue by adding a comment. You can join our community chat at Discord. A general manual about open-source contributions can be found here.

@hendrikebbers hendrikebbers added good first issue Good for newcomers help wanted Extra attention is needed hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. labels Oct 1, 2024
@abinjustinkumaravel
Copy link

Hi @hendrikebbers, I wish to contribute on this project.

@hendrikebbers
Copy link
Contributor Author

sure :) I will assign you

@hendrikebbers
Copy link
Contributor Author

@abinjustinkumaravel I assigned @perig99 since we commented earlier than you. @perig99 can you pls agree that you want to work on the issue? Otherwise I will assign @abinjustinkumaravel

@perig99 perig99 removed their assignment Oct 2, 2024
@hendrikebbers
Copy link
Contributor Author

@abinjustinkumaravel I will assign you

@abinjustinkumaravel
Copy link

@hendrikebbers yes I will do that, Thanks for this opportunity.

@abinjustinkumaravel
Copy link

Issue with Hugo Configuration File Not Being Located

Hi @hendrikebbers,

I'm encountering an issue when trying to run the project. Specifically, the hugo.toml configuration file is not being located properly. I tried installing Hugo using the following command:

sudo apt install hugo

However, I'm facing issues with the project configuration.

Here’s a screenshot of the error I'm getting:

Screenshot from 2024-10-02 21-21-38

Any help would be appreciated. Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Issues shown by lists for the Hacktoberfest and made for newcomers to do the first contribution. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants