Skip to content
This repository has been archived by the owner on Jul 26, 2024. It is now read-only.

Not compatible with 4.9.0-rc2 #1

Open
Kha opened this issue Jun 14, 2024 · 4 comments
Open

Not compatible with 4.9.0-rc2 #1

Kha opened this issue Jun 14, 2024 · 4 comments

Comments

@Kha
Copy link

Kha commented Jun 14, 2024

This breaks live.lean-lang.org's mathlib-demo update:

Jun 14 15:26:55 nixos 9nmydfvy37i74r8n5as29as7lxd0nibc-update-leanproject[3628191]:
  error: ././.lake/packages/webeditor/././Webeditor/Tools/PackageVersion.lean:38:8:
  invalid dotted identifier notation, unknown identifier `Lake.PackageEntry.path` from expected type
@joneugster
Copy link
Member

joneugster commented Jun 14, 2024

c699703
updates the package to the latest nightly.

If your projects "Latest Mathlib" and "Lean nightly" are setup to auto-update (i.e. have a build.sh file), then this should resolve itself next time they are updated

@Kha
Copy link
Author

Kha commented Jun 17, 2024

Thanks, it works now after disabling the update for mathlib-stable. It would be nice to have a webeditor@stable tag just like with Mathlib.

@joneugster
Copy link
Member

I was hoping that eventually the mixins, which you mentioned to me once, will work (or are documented) and would make the webeditor package superfluous.

@Kha
Copy link
Author

Kha commented Jun 17, 2024

Mmh, but even if there was some plugin system such that the package would not have to be listed in the lakefile, that doesn't change that its code has to be compatible with the project's Lean version. So absent some sophisticated version resolution in Lake, I don't think that really changes things here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants