Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of imports #725

Closed
mrclrchtr opened this issue Jun 26, 2024 · 2 comments
Closed

Order of imports #725

mrclrchtr opened this issue Jun 26, 2024 · 2 comments
Labels
feature 🚀 New feature or request

Comments

@mrclrchtr
Copy link

mrclrchtr commented Jun 26, 2024

Description

At first: Thanks for the tool and your effort!

Would it be possible to add ordering of the imports in the services.gen.ts (or all files, but I think the services.gen.ts is the only relevant one)?

In my case, the commit automatically sorts alphabetically and i get diffs whenever i regenerate the client.

Or is that something that should be done with prettier?
(I have already tried to implement this, but am currently running into this bug... prettier/prettier-vscode#3380)

@mrclrchtr mrclrchtr added the feature 🚀 New feature or request label Jun 26, 2024
@mrlubos
Copy link
Member

mrlubos commented Jun 26, 2024

Hey @mrclrchtr. If you can post process the generated code with Prettier, that's the best way imo. There used to be a feature for indentation and that had the same problem. When you try to infer all the formatter settings, it's easier to just run the actual formatter. Let me know if it becomes unbearably slow to run formatter, it could be revisited then

@mrclrchtr
Copy link
Author

Yes, I was expecting that. I will do post processing. Thank you for the answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants