Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.facebook.me() incorrect cb #9

Open
hiattp opened this issue Jul 1, 2012 · 0 comments
Open

req.facebook.me() incorrect cb #9

hiattp opened this issue Jul 1, 2012 · 0 comments

Comments

@hiattp
Copy link

hiattp commented Jul 1, 2012

You have:

this.me = function(cb) {
if (self.token) {
self.get('/me', function(me) {
cb(me);
});
} else {
cb();
}
}

But the successful self.get function returns cb(null,result), so it should be:

this.me = function(cb) {
if (self.token) {
self.get('/me', function(err, me) {
cb(me);
});
} else {
cb();
}
}

Sorry for not just making the edit and submitting a pull request but I made a few other changes others may not want and this is a pretty minor fix :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant