Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Swift 3.0 #48

Closed
dmitryPocopay opened this issue Sep 12, 2016 · 9 comments
Closed

Update for Swift 3.0 #48

dmitryPocopay opened this issue Sep 12, 2016 · 9 comments

Comments

@dmitryPocopay
Copy link

Hello, can this be update for the new Swift 3.0?

@dmitryPocopay dmitryPocopay changed the title Update for 3.0 Update for Swift 3.0 Sep 12, 2016
@henrinormak
Copy link
Owner

I am currently unavailable for active development, but I can try to review PRs, so, if you are willing to make the updates, I can get them reviewedand merged.

@rajeevpra
Copy link
Contributor

Hi, I spend few hours and updated it to swift 3.0, if you are willing I can submit PR. I didn't write any new tests but all your test are passing.

@henrinormak
Copy link
Owner

That would be awesome, please do submit a PR!

@rajeevpra
Copy link
Contributor

Submitted PR.. Please make sure to run tests on ios 9.x, its failing on 10.x because of the issues being discussed in #47

@LiborZ
Copy link

LiborZ commented Sep 20, 2016

I can't be much help with update to Swift 3.0 but hope you can fix it. I really need to upgrade. Thanks

@rajeevpra
Copy link
Contributor

It all working, It's failing because of test failure when its trying to run it on ios 10 simulator. This is unrelated to any changes to Swift 3 (see #47, its because of bug in ios10 simulator) , so if any of you can suggest a way to restrict tests to ios9.x in travis-ci. I tried different configurations but nothing seems to be working.

@rajeevpra
Copy link
Contributor

Done with test passing for 9.3.

@LiborZ
Copy link

LiborZ commented Oct 5, 2016

@henrinormak Can you please merge changes for Swift 3.0? Or at least create branch for Swift 3?

@henrinormak
Copy link
Owner

As I am unable to work on this or even test this, I am taking steps to adding people as collaborators to the project. Track #49 for progress on that front

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants