Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping Firefox to Dock fails, Exec= empty #28

Open
rdrms opened this issue Dec 27, 2021 · 6 comments
Open

Keeping Firefox to Dock fails, Exec= empty #28

rdrms opened this issue Dec 27, 2021 · 6 comments
Labels
bug Something isn't working

Comments

@rdrms
Copy link

rdrms commented Dec 27, 2021

Hi all, really enjoying the simplicity of this project.

One thing I just ran into is that I put Firefox pinned to the dock, but it won't launch when I open it from there. Other applications I tried seem to work fine. But for some reason, Firefox will launch just fine from the terminal, or from the System menu, but not from the dock.

Also, is there some way to rearrange the items in the dock without removing them all and then adding them again?

Thanks!

@probonopd
Copy link
Member

Hello @ryanrms, thanks for your feedback.
How did you get the Firefox version you are trying to pin to the Dock?

Currently it is not yet possible to rearrange the Dock items. We should either backport this functionality or switch to CutefishOS Dock entirely (by porting our changes such as Application Bundle support to it).

@rdrms
Copy link
Author

rdrms commented Dec 27, 2021

I got Firefox through selecting it through the system menu. I believe it was installed through pkg if my memory of the install is correct. Thanks for the reply, good luck!

@probonopd
Copy link
Member

Can you please copy and paste here the Firefox section from $HOME/.config/cyberos/dock_pinned.conf?

@rdrms
Copy link
Author

rdrms commented Dec 27, 2021

So the method I used to add it to the dock was to launch Firefox using the System -> Applications (Internet) menu, then right click the dock and click to add it. It appears it is missing the Exec line:

(...)

[Firefox]
DesktopPath=
Exec=
IconName=firefox
Index=5
visibleName=Mozilla Firefox

(...)

@probonopd
Copy link
Member

This is a bug.
Please change it to Exec=Firefox and see what happens.

When I do the following, it seems to work for me:

  • On a fresh system that does NOT have Firefox installed, run System -> Applications -> Internet -> Firefox
  • Do NOT install it but rather right-click its icon in Dock and select "Keep Firefox in Dock"
  • Click "No" to close the installer
  • Clicking the icon again will launch the installer correctly

In this case, the resulting entry is

DesktopPath=
Exec='/Applications/Internet/Firefox.app/Firefox'
IconName=file:///Applications/Internet/Firefox.app/Resources/Firefox.png
Index=6
visibleName=Firefox
  • Install Firefox
  • The icon in the Dock will still work

I can reproduce the bug like this:

  • Remove Fierfox from Dock
  • System -> Applications -> Firefox Web Browser
  • Keep Mozilla Firefox in the Dock
  • Quit Firefox
  • It will not work:
[Firefox]
DesktopPath=
Exec=
IconName=firefox
Index=6
visibleName=Mozilla Firefox

So, strangely, adding Firefox to the Dock only works as long as it is not installed.

Need to get down to the root cause of this. Most likely we need a moer robust way to find out which Application Bundle has launched a process.

@probonopd probonopd changed the title Jan 2, 2022
@probonopd probonopd transferred this issue from helloSystem/hello Jan 2, 2022
@rdrms
Copy link
Author

rdrms commented Jan 2, 2022

Changing the "Exec=" line to "Exec=firefox" opens the browser as expected.

Small note, I wasn't able to get your first method to work. I pinned the Firefox icon to the dock and cancelled the installer, but clicking on it wasn't able to get the installer to start again.

@probonopd probonopd added the bug Something isn't working label Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants