Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement deprecated sktime interface on hcrystalball #71

Open
aiwalter opened this issue May 22, 2022 · 2 comments
Open

[FEATURE] Implement deprecated sktime interface on hcrystalball #71

aiwalter opened this issue May 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@aiwalter
Copy link

Is your feature request related to a problem? Please describe.
The current sktime interface to hcrystalball is going to be deprecated soon. A solution to still use hcrystalball with sktime would be to move the wrapper from sktime package to hcrystalball package.

Describe the solution you'd like
Copy the existing code from https://github.com/alan-turing-institute/sktime/blob/main/sktime/forecasting/hcrystalball.py to hcrystalball. Tests from sktime are now also portable, whihc means they can be imported from the package and could be run on that class. See here: https://www.sktime.org/en/stable/developer_guide/testing_framework.html

@fkiraly
Copy link

fkiraly commented May 23, 2022

The current sktime interface to hcrystalball is going to be deprecated soon.

@aiwalter, we have not decided on that yet!

See discussion here. sktime/sktime#2677

@MichalChromcak
Copy link
Collaborator

Thank you for mentioning it and opening the issue here. I hope to find the time reasonably soon to do the migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants