operateWithFailover fails against c* 1.2.1 when authentication is enabled.

[biddster]

I'm kicking the tyres of cassandra 1.2.1 and have come across an issue.

I've enabled authentication using my own authenticator in cassandra. Most Hector operations fail as HConnectionManager.operateWIthFailover calls cassandraClient.set_keyspace (via client.getCassandra(op.keyspaceName) before calling c.login.

I get an InvalidRequestException (why: You have not logged in).

Looks like the code needs shuffling around to look something like this:

    client = pool.borrowClient();
     if ( op.credentials != null && !op.credentials.isEmpty() && !client.isAlreadyAuthenticated(op.credentials)) {
      client.login(op.credentials);
      client.setAuthenticated(op.credentials);
    }
    Cassandra.Client c = client.getCassandra(op.keyspaceName);

Note that this isn't a problem against c* 1.2.0. It's likely down to this bug that was fixed in 1.2.1.

https://issues.apache.org/jira/browse/CASSANDRA-5144

[zznate]

I agree the fix is straightforward, but looks like we have a forcing function to move master to tracking 1.2 now as it will be incompatible with 1.1.x and 1.0.x of cassandra.

Thanks for the details.

[biddster]

No problem, happy to contribute.

I see what you mean. Pretty sure the fix is backward compatible but it does mean you have to track 1.2.1 onwards.