Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Setting fargateFIPSMode with aws_ecs_account_setting_default resource #40443

Closed
Arlington1985 opened this issue Dec 4, 2024 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.

Comments

@Arlington1985
Copy link

Description

There is an option to set "fargateFIPSMode" for ECS account settings:
https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_PutAccountSetting.html

But currently provider version doesn't accept "fargateFIPSMode" as value. Getting following error

Error: expected name to be one of [serviceLongArnFormat taskLongArnFormat containerInstanceLongArnFormat awsvpcTrunking containerInsights], got fargateFIPSMode

Affected Resource(s) and/or Data Source(s)

  • aws_ecs_account_setting_default

Potential Terraform Configuration

resource "aws_ecs_account_setting_default" "ecs_account_setting_fips_mode" {
  name     = "fargateFIPSMode"
  value    = "enabled"
}

References

https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_PutAccountSetting.html

Would you like to implement a fix?

None

@Arlington1985 Arlington1985 added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/ecs Issues and PRs that pertain to the ecs service. needs-triage Waiting for first response or review from a maintainer. labels Dec 4, 2024
@TaxBusby
Copy link

I was hitting this with an older 4.53.0 terraform aws provider. Updating to 4.67.0 fixed it. I believe it's because the AWS SDK version was bumped between these releases.

If that doesn't match our issue, consider sharing the version of the aws provider you are using.

@justinretzolk
Copy link
Member

Hey @Arlington1985 👋 Thank you for taking the time to raise this! Can you verify what version of the AWS Provider you're using? In addition to the comment above, I took a look over the resource definition and noted that the validation for that argument pulls from SettingName from the AWS Go SDK, which includes fargateFIPSMode as an option.

@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Jan 21, 2025
@Arlington1985
Copy link
Author

Hi @justinretzolk . It's ~4.56.0 version. I guess you are right then. Sorry about that, my bad.

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot removed waiting-response Maintainers are waiting on response from community or contributor. needs-triage Waiting for first response or review from a maintainer. labels Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

No branches or pull requests

3 participants