feat: raw bytecode analysing script #768
Conversation
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
arianejasuwienas
requested review from
AlfredoG87,
attest08,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
arianejasuwienas
changed the title
| - `--previewnet`: Optional flag to use the Previewnet Mirror Node URL. | ||
| - `--testnet`: Optional flag to use the Testnet Mirror Node URL. | ||
|
|
||
| If no network flag is specified, the script defaults to using the Mainnet Mirror Node URL. |
There was a problem hiding this comment.
I would prefer we switch this. Default to testnet and let people set a flag to point to mainnet.
| method_detected = True | ||
| if instruction.operand == '03' and instruction.name == 'PUSH1': | ||
| param_detected = True | ||
| if instruction.name == 'CALL': |
There was a problem hiding this comment.
GIven L21-22 does this ever get executed? I think things might need to get rearranged.
| address_detected = True | ||
| if instruction.operand in ['0fb65bf3', '2af0c59a', 'ea83f293', 'abb54eb5']: | ||
| method_detected = True | ||
| if instruction.operand == '03' and instruction.name == 'PUSH1': |
There was a problem hiding this comment.
Might be worth (for self-documenting purposes) to give a name to '03'. (I'm thinking that people will adapt this script for their own investigations and where the selectors in L25 above are kind of obviously selectors this naked '03' isn't obviously ... anything in particular ... so they might be wondering whether it's something they should change or not.) (I could go either way on the '0167' but in the context of a script named ...token_creation... it's recognizable as the system contract address.)
| call_detected = False | ||
|
|
||
| evm_bytecode = EvmBytecode(bytecode) | ||
| disassembled_code = evm_bytecode.disassemble() |
There was a problem hiding this comment.
Amazing how this library makes this simple script so easy!
|
P.S. I like the way the readme carefully documents the limitations. This is a great script to easily / quickly find the contracts that might qualify, then you need to investigate more closely to really understand them. As people adapt this script for their own investigations they'll need to keep this in mind ... |
…y contract id but contract evm address as well. Fixing issue with the latest commit. Exporting some of the strings to the constant in order to ensure clarity. Signed-off-by: Mariusz Jasuwienas <[email protected]>
…y contract id but contract evm address as well. Fixing issue with the latest commit. Exporting some of the strings to the constant in order to ensure clarity. Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
* feat: Raw bytecode analyser Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: Raw bytecode analyser Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: Adding information about the possibility to use in args not only contract id but contract evm address as well. Fixing issue with the latest commit. Exporting some of the strings to the constant in order to ensure clarity. Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: Adding information about the possibility to use in args not only contract id but contract evm address as well. Fixing issue with the latest commit. Exporting some of the strings to the constant in order to ensure clarity. Signed-off-by: Mariusz Jasuwienas <[email protected]> * feat: making sure that the description covers all possible usecases Signed-off-by: Mariusz Jasuwienas <[email protected]> --------- Signed-off-by: Mariusz Jasuwienas <[email protected]>
Description:
Raw bytecode analysing tool