You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the hedera start command show the UI in the command line temporarily and then fails with:
─Consensus Node Log─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│[Hedera-Local-Node] INFO (RecoveryState) ⏳ Starting Recovery State... │
│[Hedera-Local-Node] INFO (RecoveryState) ⏳ Trying to startup again... │[Hedera-Local-Node] INFO (StartState) ⏳ Detecting network...
│[Hedera-Local-Node] INFO (ConnectionService) Mirror Node GRPC not yet available at: 127.0.0.1:5600. Retrying... │
│[Hedera-Local-Node] INFO (ConnectionService) Mirror Node GRPC not yet available at: 127.0.0.1:5600. Retrying... │
│[Hedera-Local-Node] INFO (ConnectionService) Mirror Node GRPC not yet available at: 127.0.0.1:5600. Retrying...
...
[Hedera-Local-Node] INFO (InitState) [✔︎] Needed bootsrap properties were set for this configuration.
[Hedera-Local-Node] INFO (InitState) [✔︎] Needed mirror node properties were set for this configuration.
[Hedera-Local-Node] INFO (StartState) ⏳ Starting Hedera Local Node...
──────────────────────────────────────────────────────────────────────────────
Error on xterm-256color.Setulc:
"\u001b[58::2::%p1%{65536}%/%d::%p1%{256}%/%{255}%&%d::%p1%{255}%&%d%;m"
var v,
stack = [],
out = ["\x1b[58::2::"];
(stack.push(v = params[0]),
v),
(stack.push(v = 65536),
v),
(v = stack.pop(),
stack.push(v = (stack.pop() / v) || 0),
v),
out.push(stack.pop()),
out.push("::"),
(stack.push(v = params[0]),
v),
(stack.push(v = 256),
v),
(v = stack.pop(),
stack.push(v = (stack.pop() / v) || 0),
v),
(stack.push(v = 255),
v),
(v = stack.pop(),
stack.push(v = (stack.pop() & v) || 0),
v),
out.push(stack.pop()),
out.push("::"),
(stack.push(v = params[0]),
v),
(stack.push(v = 255),
v),
(v = stack.pop(),
stack.push(v = (stack.pop() & v) || 0),
v),
out.push(stack.pop())}out.push("m");
return out.join("");
The PR completely deprecates the Sunset TUI because it does not reach the desired user experience. Also, it depends on the local user's terminal and might cause unnecessary debugging overhead.
Removing tui makes the detached flag useless, so it's removed as well in this PR.
@natanasow does this leave a feature gap for users or was this always a nice to have?
We'll want to make sure the UI didn't present any information that isn't available in log outputs or already known to user.
Additionally are we considering a future item to replace it or does this totally remove the terminal interface?
@Nana-EC This was always nice to have. The UI doesn't present any information that isn't available through logs. We are totally removing the terminal user interface and we will stick to simple CLI tools like some Ethereum local nodes.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
natanasow
requested review from
a team,
georgi-l95,
Ivo-Yankov,
konstantinabl and
victor-yanev
as code owners
Description:
Running the hedera start command show the UI in the command line temporarily and then fails with:
The PR completely deprecates the Sunset TUI because it does not reach the desired user experience. Also, it depends on the local user's terminal and might cause unnecessary debugging overhead.
Removing tui makes the
detachedflag useless, so it's removed as well in this PR.Related issue(s):
Fixes #820
Notes for reviewer:
Checklist