Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror subscription: Catch up with SDK changes #412

Open
gregscullard opened this issue Feb 19, 2020 · 0 comments
Open

mirror subscription: Catch up with SDK changes #412

gregscullard opened this issue Feb 19, 2020 · 0 comments
Labels
bug Something isn't working P2

Comments

@gregscullard
Copy link
Contributor

gregscullard commented Feb 19, 2020

Detailed Description
Mirror node is going to start rejecting calls to subscribeTopic for topics that don't exist and return GRPC NOT_FOUND.
Will also reject calls with an entity that does exist but is not a topic with INVALID_ARGUMENT.
The SDK will:
When "NOT FOUND", try again with exponential back-off, eventually give up with error.
When "INVALID_ARGUMENT" give up with error

Actual Behavior
mirror subscription and relay don't handle these error situations

Expected Behavior
Handle error from SDK

@gregscullard gregscullard added bug Something isn't working P2 labels Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

No branches or pull requests

1 participant