Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App commands should all accept -e option to set HANAMI_ENV #75

Open
timriley opened this issue Dec 20, 2022 · 1 comment
Open

App commands should all accept -e option to set HANAMI_ENV #75

timriley opened this issue Dec 20, 2022 · 1 comment

Comments

@timriley
Copy link
Member

No description provided.

@jodosha
Copy link
Member

jodosha commented Dec 20, 2022

@timriley I'm torn.

Wouldn't this complicate the understanding and implementation of CLI?
If we introduce -e it will create a matrix of possibilities: CLI argument vs ENV var.

ENV CLI Result
not set not set Apply default: development, unless running tests (default is test)
set not set Apply given ENV var
not set set Apply given CLI arg, but also force HANAMI_ENV value to propagate the choice
set set Who's gonna win?

This will be complicated to communicate and let people wrap their heads around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants