Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua-resty-iputils vs lua-libcidr-ffi performance #19

Open
louishot opened this issue Apr 5, 2020 · 3 comments
Open

lua-resty-iputils vs lua-libcidr-ffi performance #19

louishot opened this issue Apr 5, 2020 · 3 comments

Comments

@louishot
Copy link

louishot commented Apr 5, 2020

Which one is better?

@hamishforbes
Copy link
Owner

Maybe you could run some benchmarks and let us all know?

@louishot
Copy link
Author

louishot commented Apr 6, 2020

Maybe you could run some benchmarks and let us all know?

ya I can try it If No existing benchmark data

@louishot
Copy link
Author

louishot commented Apr 6, 2020

Maybe you could run some benchmarks and let us all know?
#4
I see "When I benchmarked the pure Lua implementations against libcidr-ffi, libcidr-ffi was quite a bit faster, particularly for IPv6 (sorry I don't have any numbers handy anymore). But I'll put a big caveat around this, since I was just hacking around with copying and pasting those existing Lua implementations and trying to make them work--I'm not sure if what I managed to implement was very optimized. A more optimized pure Lua approach might be possible. And while the performance difference in micro-benchmarks was noticeable, I'm not sure if it would really have that much of a real world impact."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants