Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please specify what versions of Benchmark.net are compatible with the current Expecto release in the README #495

Open
sonicbhoc opened this issue Mar 29, 2024 · 3 comments

Comments

@sonicbhoc
Copy link

BenchmarkDotNet's IConfig interface has changed multiple times over the years, and the latest version pulled in by nuget (0.13.12) is incompatible with expecto. The error message I get is:

System.TypeLoadException: Method 'GetEventProcessors' in type 'BenchmarkConfig' from assembly 'Expecto.BenchmarkDotNet, Version=10.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

Turns out that this is a new field added in BenchmarkDotNet v0.13.9.

I would suggest clearly mentioning somewhere visible (like the README) what version of BenchmarkDotNet each version of Expecto is tested against just to make it clear what version of the library works.

@farlee2121
Copy link
Collaborator

I could get that reviewed and merged real quick if you'd like to draft up a change.

@sonicbhoc
Copy link
Author

I can take a crack at it soon. I am a little swamped right now though.

@Numpsy
Copy link
Contributor

Numpsy commented Aug 9, 2024

On the subject of BenchmarkDotNet - there is a new 0.14.0 release which has some useful new features / fixes - are there any thoughts on updating to that if there are breaking API changes within the 0.13.X set anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants