-
-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Microsoft.Extensins.Logging
instead of an internal home brew logging
#454
Comments
It makes sense to me at a high level, but I don't know enough about the original motivations for using a custom logger. |
I would guess because Microsoft.Extensions.Logging did not exist when Expecto was first built. That, and I can definitely understand wanting to dogfood Logary. @haf is that accurate? Regardless I also think this is a good idea. I'm usually using MEL ILogger in my own code under test anyway, so I have to use an adapter from the Expecto logger -> ILogger. If Expecto used ILogger directly, I'd be able to remove these adapters. Expecto could also use FSharp.Logf to keep the FSharp-y semantics. |
Yes, accurate. |
Would Logary also need to implement |
I propose rewriting the logging stack to the standard
Microsoft.Extensins.Logging
andILogger
class usage to be consistent and support structural logging.Please approve if you agree.
The text was updated successfully, but these errors were encountered: