Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to "Schedule Monthly" workflow #7614

Open
1 task
t-will-gillis opened this issue Oct 20, 2024 · 1 comment
Open
1 task

Adjustment to "Schedule Monthly" workflow #7614

t-will-gillis opened this issue Oct 20, 2024 · 1 comment
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Draft Issue is still in the process of being created Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours

Comments

@t-will-gillis
Copy link
Member

Overview

The "Schedule Monthly" workflow is keeping inactive devs on the Roster longer than desirable. This is partially due to the way that the workflow handles the July and December breaks. We need to adjust the timeline for the oneMonth variable in August and January.

Action Items

In get-contributors-data.js, replace:

// The Feb. 1st and Sept. 1st runs account for skipped months: 'oneMonth' & 'twoMonths' = 2 & 3 months respectively
let today = new Date();
let oneMonth = (today.getMonth() === 1 || today.getMonth() === 8) ? 2 : 1;
let twoMonths = (today.getMonth() === 1 || today.getMonth() === 8) ? 3 : 2;

let oneMonthAgo = new Date();                              // oneMonthAgo instantiated with date of "today"
oneMonthAgo.setMonth(oneMonthAgo.getMonth() - oneMonth);   // then set oneMonthAgo from "today"

with:

// The Feb. 1st and Sept. 1st runs account for skipped months: 'oneMonth' & 'twoMonths' = 1 & 3 months respectively
let today = new Date();
let twoMonths = (today.getMonth() === 1 || today.getMonth() === 8) ? 3 : 2;

let oneMonthAgo = new Date();                                           // oneMonthAgo instantiated with date of "today"
oneMonthAgo.setMonth(oneMonthAgo.getMonth() - 1);   // then set oneMonthAgo from "today"
  • Although this issue involves a GitHub Action, testing is not required.

Resources/Instructions

@t-will-gillis t-will-gillis added role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours labels Oct 20, 2024
@t-will-gillis t-will-gillis self-assigned this Oct 21, 2024
@t-will-gillis t-will-gillis added the Draft Issue is still in the process of being created label Oct 21, 2024
@HackforLABot
Copy link
Contributor

Hi @t-will-gillis, we notice that you are assigned to an issue that you authored. Please remember to add the Draft label to this issue while you are working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Draft Issue is still in the process of being created Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours
Projects
Status: New Issue Approval
Development

No branches or pull requests

2 participants