Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Fix browser issue in datetimepicker version 2.3.12 #356

Open
ThomProbst opened this issue Aug 21, 2017 · 4 comments
Open

Fix browser issue in datetimepicker version 2.3.12 #356

ThomProbst opened this issue Aug 21, 2017 · 4 comments

Comments

@ThomProbst
Copy link

datetimepicker 2.3.11 and before relies on the output of new Date().toString() in a buggy way.

Expected output: Fri Aug 18 2017 15:59:09 GMT+0200 (Central Europe Daylight Time)
Actual output in some browsers: Fri Aug 18 2017 15:59:59 GMT+0200

Buggy code: this.defaultTimeZone = (new Date).toString().split("(")[1].slice(0, -1);

This is fixed in version 2.3.12 of datetimepicker. Please upgrade to at least this version (current version is 2.4.4) .

I could provide a pull request if you like.

@sjardine
Copy link
Member

Please provide a PR and I will merge. Thanks!

@ThomProbst
Copy link
Author

Thank you!
It seems that I've no permission to push my branch "bugfix/..." for creating a PR.

@sjardine
Copy link
Member

sjardine commented Sep 1, 2017

You need to fork the repository, make your change, commit, push, etc....and then create a pr. No need to create a new branch.

@kosmonaffft
Copy link

Can you release version (maybe 0.9.5) with this fix included?

@sjardine sjardine transferred this issue from gwtbootstrap3/gwtbootstrap3 Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants