Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IConsoleDriver #3846

Closed
tznind opened this issue Nov 23, 2024 · 1 comment
Closed

Add IConsoleDriver #3846

tznind opened this issue Nov 23, 2024 · 1 comment
Labels
enhancement v2 For discussions, issues, etc... relavant for v2

Comments

@tznind
Copy link
Collaborator

tznind commented Nov 23, 2024

Is your feature request related to a problem? Please describe.
A very useful step towards #3837 would be if everyone who referenced Driver especially Application.Driver hit an interface instead of a concrete class.

This would enable me to write a facade that makes the new system look like the old driver.

Describe the solution you'd like
Add IConsoleDriver interface and replace all properties/fields/static references to ConsoleDriver to IConsoleDriver

Describe alternatives you've considered
I could make the changes in my own branch but I think that would be a mistake.

This is useful work in general so would fit in to v2_develop directly and doesnt need to be tied to #3837

@tznind tznind added enhancement v2 For discussions, issues, etc... relavant for v2 labels Nov 23, 2024
@tznind
Copy link
Collaborator Author

tznind commented Nov 23, 2024

Looks like ReSharper might do this as a one click 'ReSharper > Refactor > Extract Interface'

I will have a try tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement v2 For discussions, issues, etc... relavant for v2
Projects
None yet
Development

No branches or pull requests

1 participant