Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using_All_Culture_StandardizeDateFormat test takes 20 seconds to run #3792

Open
tig opened this issue Oct 11, 2024 · 2 comments
Open

Using_All_Culture_StandardizeDateFormat test takes 20 seconds to run #3792

tig opened this issue Oct 11, 2024 · 2 comments
Assignees
Labels
bug testing Issues related to testing
Milestone

Comments

@tig
Copy link
Collaborator

tig commented Oct 11, 2024

image

CultureInfo.GetCultures (CultureTypes.AllCultures) returns almost 1000 culstures.

Can we use CultureTypes.NeutralCultures instead? This cuts the test time down to 3 seconds (250 cultures).

Or, is there something else that can be done to reduce the time this takes?

@tig tig added bug testing Issues related to testing labels Oct 11, 2024
@tig tig added this to the V2 Alpha milestone Oct 11, 2024
@BDisp
Copy link
Collaborator

BDisp commented Oct 11, 2024

The test is really test all cultures, which is the finality if this test. If it's to test only CultureTypes.NeutralCultures then the existent unit test doesn't make sense and thus you can add the [Fact (Skip="Take to long time to run")].

@tig
Copy link
Collaborator Author

tig commented Oct 11, 2024

You know far more about cultures than I. I need your help figuring out what the right thing to do is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testing Issues related to testing
Projects
Status: No status
Development

No branches or pull requests

2 participants