Review Usage Of CacheTime.Facia For Image, Media And Gallery Content

[JamieB-gu]

When this content is rendered by DCAR, we're using CacheTime.Facia to set the cache time:

frontend/common/app/renderers/DotcomRenderingService.scala

Line 361 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + "/Article", CacheTime.Facia)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 372 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + "/AppsArticle", CacheTime.Facia)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 384 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + "/Article", CacheTime.Facia)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 396 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + "/AppsArticle", CacheTime.Facia)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 408 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + "/Article", CacheTime.Facia)

This is designed for "facia" content (fronts, tag pages, etc.), so may not be what we want for articles. It might be preferable to instead base the cache time on the metadata, as we do for most other articles:

frontend/common/app/renderers/DotcomRenderingService.scala

Line 215 in c7b403b

post(ws, json, Configuration.rendering.articleBaseURL + path, page.metadata.cacheTime)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 311 in c7b403b

post(ws, json, Configuration.rendering.interactiveBaseURL + "/Interactive", page.metadata.cacheTime, 4.seconds)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 323 in c7b403b

post(ws, json, Configuration.rendering.interactiveBaseURL + "/AMPInteractive", page.metadata.cacheTime)

frontend/common/app/renderers/DotcomRenderingService.scala

Line 339 in c7b403b

post(ws, json, Configuration.rendering.interactiveBaseURL + "/AppsInteractive", page.metadata.cacheTime, 4.seconds)