Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoscaling group must have a max larger than min #39

Open
mbarton opened this issue May 23, 2019 · 2 comments
Open

Autoscaling group must have a max larger than min #39

mbarton opened this issue May 23, 2019 · 2 comments
Assignees

Comments

@mbarton
Copy link
Contributor

mbarton commented May 23, 2019

#32 re-attaches the old instance to the AutoScaling group, which means it must have a max >= min + 1.

I'm probably missing something but would it be easier to create the new instance by simply bumping the DesiredCapacity of the ASG rather than detaching an existing instance?

@mbarton mbarton self-assigned this May 23, 2019
@tomrf1
Copy link
Member

tomrf1 commented May 24, 2019

I'm not sure about the reasoning behind the PR you link to, but we had to detach the oldest instance rather than increase the ASG size by one to ensure AZ balance. See #16

@mbarton
Copy link
Contributor Author

mbarton commented May 24, 2019

Ah makes sense. @rtyley was it intentional that #32 needs max=(min+ 1)? Happy to run through in person

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants