Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Discussions in DCAR #10023

Closed
mxdvl opened this issue Jan 2, 2024 · 2 comments
Closed

[EPIC] Discussions in DCAR #10023

mxdvl opened this issue Jan 2, 2024 · 2 comments
Labels

Comments

@mxdvl
Copy link
Contributor

mxdvl commented Jan 2, 2024

Important

Duplicate of #8745

This quarter (Jan-Mar 2024) we’ll be working on implementing discussions in DCAR. We hope will reduce the amount of platform-specific logic in favour of a unified approach. We may also use this as an opportunity to simpliying existing the code and fix bugs.

Rough tasks that need addressing

  • How does sign-in works with Bridget?
  • How do fetch requests work in WebViews?
  • How is saving preferences handled?
  • How should discussion behave when offline?
@alinaboghiu
Copy link
Member

From Jame's original epic ticket:

"Discussion in web and Apps differs in that in Apps post endpoints interact with the native layer directly as that's where the user information is know. e.g. postComment or reportAbuse

There has been some work to account for this by using callbacks on the CommentContainer.

When migrating discussion-rendering we had opted for expediency to not always follow this pattern, so will need to find those interactions that speak to the discussion API directly and port them over to the paradigm above.

We might need to work with Apps here to help create any endpoints that don't exist."

@mxdvl mxdvl modified the milestones: DCR for Apps, Discussion for Apps Jan 4, 2024
@mxdvl
Copy link
Contributor Author

mxdvl commented Jan 5, 2024

Duplicate of #8745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants