Update download-artifact to v4 following deprecation of v3 #37
Conversation
|
Presumably this build failed because we also need to update download-artifact to v4? I’ll push a commit and see if the build then passes. |
|
Oh sorry, this PR just updates the test, presumably as a demonstration of what needs to be supported. Never mind! |
Reading through the migration guides [for download-artifact@v4](https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md) and [for upload-artifact@v4](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md), I don’t think we’re currently using any of the features of v3 that have been removed in v4. So I think just updating the version numbers should be sufficient.
|
I tested this update in https://github.com/guardian/content-pipeline-docs/pull/10 and it seems to have worked! This build succeeded, and then I deployed it successfully, producing a working resulting site. |
emdash-ie
changed the title
|
Because this is require to be a major version, I would rather include more changes in the v3: #23 |
That's fair – if we merge this PR first and update to v3 and then merge yours and update to v4, that's two version upgrades for any consumers of the action. I worry though that your PR is further from merging and waiting for it will mean consumers of actions-static-site will be unable to update their sites for a while. Searching for consumers I don't see anything that stands out to me as very important to avoid that kind of breakage for though. |
What does this change?
Github has sent us a notice that v3 of this action will be deprecated by December 5, 2024., so we need to switch to v4.
Fixes #38