Skip to content
This repository has been archived by the owner on May 1, 2022. It is now read-only.

Old nokogiri version #2

Open
kevinansfield opened this issue Oct 27, 2010 · 3 comments
Open

Old nokogiri version #2

kevinansfield opened this issue Oct 27, 2010 · 3 comments

Comments

@kevinansfield
Copy link

acts_as_sanitiled is locked to the 1.3.x version of nokogiri yet the current version is 1.4.x

This is causing me some issues as it prevents bundler from being able to use the latest version of fog which has some important fixes for EU buckets. Does the 1.4 branch of acts_as_sanitiled work ok? Is there some way of testing easily?

@gtd
Copy link
Owner

gtd commented Oct 28, 2010

Varying combinations of nokogiri, libxml, sanitize, redcloth, and ruby all interact to create some weird scenarios. When I get a chance I'll update it to some aggressive minimum version which should hopefully solve your problem.

@kevinansfield
Copy link
Author

Are there specs for these weird scenarios?

On my fork at http://github.com/kevinansfield/acts_as_sanitiled I have updated it to work with ruby 1.9.2/rails 3 (there may be a better more backwards-compatible way of doing this - I just needed it to work quickly) and updated the gemspec to work with the latest versions of nokogiri/sanitize, after which all the included specs are passing.

@gtd
Copy link
Owner

gtd commented Oct 28, 2010

Well I've run into some random problems and spec failures, but it's hard to formalize a test without using a lot of heavyweight infrastructure involving rvm. I'm loathe to do so because much like Mr Wanstrath I've come to question the magical nature of the ActsAsTextiled architecture, given how it ineteracts with other features/plugins such as validates_length_of or Globalize2, and given the relative painlessness of just saying what you mean in templates.

My approach will probably just be to push the minimum supported requirements for the plugin forward and try to keep it up to date. When I get a chance I'll take a look at your branch and pull it in if it looks good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants