Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to avoid logging a cancelled operation as an error? #44

Open
bboreham opened this issue Jun 8, 2018 · 1 comment
Open

How to avoid logging a cancelled operation as an error? #44

bboreham opened this issue Jun 8, 2018 · 1 comment

Comments

@bboreham
Copy link

bboreham commented Jun 8, 2018

In our system we fire off calls to multiple servers, use the results that come back first and cancel the slowest ones. Unfortunately the cancelled ones show up as an error in tracing, because of this line

Any suggestions how to improve this? Could be another kind of Option ?

(I can write the PR if you think the idea is worthwhile)

@bboreham
Copy link
Author

bboreham commented Sep 5, 2018

I followed the code through a little further to SetSpanTags where it correctly detects the operation was cancelled which is in "Success" class, but because client is true it is set as an error.

Could we have Success override client ? What was the intention of that line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant