Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_query_parameter_u64_with_offset is broken #302

Open
kvark opened this issue Sep 11, 2024 · 3 comments
Open

get_query_parameter_u64_with_offset is broken #302

kvark opened this issue Sep 11, 2024 · 3 comments

Comments

@kvark
Copy link
Contributor

kvark commented Sep 11, 2024

Looks like it accepts an offset and passes it to GL as a pointer?
I think it needs to be 2 variations of this function: one where you pass a buffer with offset, and another where you pass a pointer. Similar to glReadPixels and friends.

@grovesNL
Copy link
Owner

Looks like it was added in #260

@Zoxc do you remember why it was set up this way, or maybe an example of how you were testing it with query objects? Just wondering if it's missing something here

@Zoxc
Copy link
Contributor

Zoxc commented Sep 17, 2024

I made it take usize because this library seem to prefer typical Rust types when possible. An additional variant which uses a pointer would also make sense. The offset variant makes it clear that you're not actually passing a pointer.

@Zoxc
Copy link
Contributor

Zoxc commented Sep 17, 2024

I used this function here and tested it with wgpu_profiler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants