Add donate page #78
Closed
Add donate page #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i believe i've learned how to implement this using QDialog and QCard, removing the need for a separate page, and instead showing a card overlay on the main screen. this will look a lot nicer and be less disruptive to the UX. i will create a separate PR for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a separate donate page, with separate PayPal, OC, and GH donation icons & buttons. Admittedly, it's a bit ugly looking, but it adds the required functionality. I've also had to put the 28x28 minified icons in the
src/staticsdirectory, since I couldn't find any free CDN distributing these icons.Future work
I would argue that the entire app needs a UI overhaul, so I'd like to defer donation page design to later. I will open an issue about this. A good first step is to write a unified SCSS template for the app, define the UI colors, and minimize copy-paste of specific hex values.
Related issues