Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Update the way the nav height is calculated in the sidebar viewport component #3432

Open
xelaint opened this issue Jan 14, 2025 · 0 comments · May be fixed by #2714
Open

[FEAT] Update the way the nav height is calculated in the sidebar viewport component #3432

xelaint opened this issue Jan 14, 2025 · 0 comments · May be fixed by #2714
Assignees
Labels
package: design @daffodil/design
Milestone

Comments

@xelaint
Copy link
Member

xelaint commented Jan 14, 2025

💡 Feature request

Feature Name

The Desired Behavior

--daff-sidebar-side-fixed-top-shift is currently a fixed value, but this causes issues when a border bottom is added to the viewport nav. The sidebar ends up hiding the bottom border.

image

Your Use Case

As a designer, I'd like to be able to add a border-bottom to the daffio-header and have the --daff-sidebar-side-fixed-top-shift value adjust accordingly.

Prior Work

Environment


Daffodil version: X.Y.Z
Angular version: X.Y.Z 

 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@xelaint xelaint added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Jan 14, 2025
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 14, 2025
@xelaint xelaint self-assigned this Jan 14, 2025
@xelaint xelaint linked a pull request Jan 14, 2025 that will close this issue
3 tasks
@xelaint xelaint removed the feat a new feature, enhancement, or improvement label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant