Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Make design components hydration compatible #3426

Open
griest024 opened this issue Jan 13, 2025 · 2 comments
Open

[FEAT] Make design components hydration compatible #3426

griest024 opened this issue Jan 13, 2025 · 2 comments
Assignees
Labels
package: design @daffodil/design
Milestone

Comments

@griest024
Copy link
Member

We should avoid direct DOM manipulation in design components as this will break hydration. Its also an open issue that template outlets break hydration and require a workaround. This issue should track the various instances of design components that currently have hydration-incompatible implementations:

@griest024 griest024 added feat a new feature, enhancement, or improvement package: design @daffodil/design labels Jan 13, 2025
@griest024 griest024 added this to the Daffodil v1.0 milestone Jan 13, 2025
@xelaint
Copy link
Member

xelaint commented Jan 13, 2025

@griest024 So does this mean we're not able to use ngTemplateOutlet at all?

@griest024
Copy link
Member Author

@griest024 So does this mean we're not able to use ngTemplateOutlet at all?

No, we can use it, but we have to place an <ng-content /> at the beginning of the template whenever we do. Its a weird workaround but its the offically recommended one.

@xelaint xelaint removed the feat a new feature, enhancement, or improvement label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

No branches or pull requests

3 participants