Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth server doesn't delete headless auth request when tsh --headless command is canceled #48569

Open
ravicious opened this issue Nov 7, 2024 · 0 comments
Assignees
Labels
bug test-plan-problem Issues which have been surfaced by running the manual release test plan

Comments

@ravicious
Copy link
Member

ravicious commented Nov 7, 2024

  1. Log in to a cluster in Connect.
  2. Outside of Connect, execute a tsh command with --headless.
  3. Wait for the headless auth modal to show up in Connect.
  4. Cancel the tsh command.

At this point, the modal should disappear. This used to work in v16.0.0, but it didn't work during the v17 test plan. Initially I assumed it's a problem with grpc-js, but it also doesn't work in Connect/tsh v16 when talking to a v17 cluster. I think this points to the issue being on the server side where OpDelete is not sent to clients.

case types.OpDelete:
cancelPendingRequest(event.Resource.GetName())

@ravicious ravicious added bug test-plan-problem Issues which have been surfaced by running the manual release test plan labels Nov 7, 2024
@ravicious ravicious changed the title Auth server doesn't delete headless auth request when tsh --headless command in canceled Auth server doesn't delete headless auth request when tsh --headless command is canceled Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug test-plan-problem Issues which have been surfaced by running the manual release test plan
Projects
None yet
Development

No branches or pull requests

2 participants