You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fetchKubeNamespaces uses clusterUri to query for namespaces. However, clusterUri comes from the cluster selector to the left of the search bar, present only if there are leaf clusters. If someone adds root kube cluster to a request and then goes to browse a leaf Teleport cluster, then opens the checkout and tries to modify requested namespaces, that request is going to either fail or return wrong data. Unless both the root cluster and the leaf cluster have a kube cluster with the same name and the same namespaces.
To fix this, fetchKubeNamespaces would at least need to provide the name of the cluster that the kube cluster belongs to. Ideally, the shared components in access requests would operate on some kind of URIs so that a single identifier points at a specific kube cluster.
On top of that, the ListKubernetesResourcesRequest gRPC message should operate on a single kubeClusterUri to identify the kube cluster, not on a combo of cluster_uri + kubernetes_cluster. This is possible today without any changes to the shared access request components.
The text was updated successfully, but these errors were encountered:
teleport/web/packages/teleterm/src/ui/AccessRequestCheckout/useAccessRequestCheckout.ts
Lines 401 to 417 in ee1726e
fetchKubeNamespaces
usesclusterUri
to query for namespaces. However,clusterUri
comes from the cluster selector to the left of the search bar, present only if there are leaf clusters. If someone adds root kube cluster to a request and then goes to browse a leaf Teleport cluster, then opens the checkout and tries to modify requested namespaces, that request is going to either fail or return wrong data. Unless both the root cluster and the leaf cluster have a kube cluster with the same name and the same namespaces.To fix this,
fetchKubeNamespaces
would at least need to provide the name of the cluster that the kube cluster belongs to. Ideally, the shared components in access requests would operate on some kind of URIs so that a single identifier points at a specific kube cluster.On top of that, the
ListKubernetesResourcesRequest
gRPC message should operate on a singlekubeClusterUri
to identify the kube cluster, not on a combo ofcluster_uri
+kubernetes_cluster
. This is possible today without any changes to the shared access request components.The text was updated successfully, but these errors were encountered: