Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous feedback regarding the merge stage spec text #142

Open
glen-84 opened this issue Jan 17, 2025 · 0 comments
Open

Miscellaneous feedback regarding the merge stage spec text #142

glen-84 opened this issue Jan 17, 2025 · 0 comments

Comments

@glen-84
Copy link
Contributor

glen-84 commented Jan 17, 2025

  1. "Let description be the description of argumentA or undefined if none exists."

    Should we use null here instead of undefined?

  2. https://graphql.github.io/composite-schemas-spec/draft/#sec-Merge-Argument.Service-A – should this heading be removed?

  3. https://github.com/graphql/composite-schemas-spec/blame/main/spec/Section%204%20--%20Composition.md#L3566-L3568

    When only one enum definition is present (after removing any inaccessible ones)

    Referring to the text in parentheses, if one of the definitions was inaccessible, then wouldn't they all be inaccessible, and there would be none left to merge? (for the composite schema, not the execution schema)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant