Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_default_scalars option #437

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add skip_default_scalars option #437

wants to merge 2 commits into from

Conversation

fenhl
Copy link

@fenhl fenhl commented Sep 21, 2022

Closes #432.

tomhoule
tomhoule reviewed Sep 23, 2022
View reviewed changes
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. It is only missing tests. Would you be prepared to write one? I think we would want to test that including that option, providing custom types for some of the default scalars and deserializing a specific JSON file, we have the values we expect.

mathstuf
mathstuf requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@mathstuf mathstuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; just needs tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule left review comments

@mathstuf mathstuf mathstuf requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip default scalars
3 participants
@fenhl @mathstuf @tomhoule