Default import of java.time.* #346
Conversation
codeconsole
force-pushed
the
7.0.x-datetime
branch
from
333b05b to
c97acd9
Compare
src/main/groovy/org/grails/gradle/plugin/core/GrailsExtension.groovy
Outdated
Show resolved
Hide resolved
| @@ -652,6 +654,31 @@ class GrailsGradlePlugin extends GroovyPlugin { | |||
| output?.classesDirs ?: project.files(new File(project.buildDir, "classes/main")) | |||
| } | |||
|
|
|||
| protected void configureJavaTime(Project project) { | |||
There was a problem hiding this comment.
Is autoImportDateTimeApi(Project project) a more descriptive name?
There was a problem hiding this comment.
I think this isn't just auto importing DateTime. I think it is importing java.time.*. Is that the case? If it is, I don't think autoImportDateTimeApi is a good name.
There was a problem hiding this comment.
Well, autoImportDateTimeApi is at least the sentiment of what we are trying to do. There are of course a couple of sub-packages that also belong to the DateTime Api.
There was a problem hiding this comment.
I understand now. Thank you!
There was a problem hiding this comment.
@matrei my sentiment was always just import java.time.* and that is why I named it JavaTime. Are you suggesting we should import everything else?
java.time.chrono.*
java.time.format.*
java.time.temporal.*
java.time.zone.*
There was a problem hiding this comment.
Are you suggesting we should import everything else?
I don't know. Are there any drawbacks?
There was a problem hiding this comment.
not sure if it is necessary or needed.
There was a problem hiding this comment.
the groovy examples only needed:
import java.time.*
import static java.time.temporal.ChronoField.*
import java.time.temporal.ChronoUnit
import java.time.format.FormatStyleto work
There was a problem hiding this comment.
@matrei drawback is that I am not a fan of start imports to begin with, but I feel we need to offer a smooth painless transition away from the java Date class.
src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
src/main/groovy/org/grails/gradle/plugin/core/GrailsGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
| @@ -654,31 +674,6 @@ class GrailsGradlePlugin extends GroovyPlugin { | |||
| output?.classesDirs ?: project.files(new File(project.buildDir, "classes/main")) | |||
| } | |||
|
|
|||
| protected void configureJavaTime(Project project) { | |||
There was a problem hiding this comment.
Actually, I meant to keep this method (although with a different name), and call it from the configureGroovy method.
protected void configureGroovy(Project project) {
// some other stuff
if (grailsExt.autoImportDateTimeApi) {
autoImportDateTimeApi(project)
}
}
|
I am going to merge this. I am not opposed to any changes. I just want to keep things moving. The discussion can continue and this can continue to evolve, but there are other areas right now where this needs to be expanded on and the work can not continue without the merge. For instance, LocalDateTime currently does not render an input. Let's continue discussion in #345 |
Enables smooth transition from legacy java.util.Date to java.time
Fixes #345