From 1f22ceec0fc08b3802c9e8a7c7bd7bece4c781d3 Mon Sep 17 00:00:00 2001 From: Owen Diehl Date: Wed, 20 Mar 2024 08:17:51 -0700 Subject: [PATCH] legacy index reader getshards Signed-off-by: Owen Diehl --- pkg/storage/stores/series/series_index_store.go | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/pkg/storage/stores/series/series_index_store.go b/pkg/storage/stores/series/series_index_store.go index 1bd74e50b58f..c6fb916c53d8 100644 --- a/pkg/storage/stores/series/series_index_store.go +++ b/pkg/storage/stores/series/series_index_store.go @@ -2,8 +2,8 @@ package series import ( "context" - "errors" "fmt" + "math" "sort" "sync" @@ -761,6 +761,7 @@ func (c *IndexReaderWriter) Volume(_ context.Context, _ string, _, _ model.Time, return nil, nil } +// old index stores do not implement dynamic sharidng -- skip func (c *IndexReaderWriter) GetShards( _ context.Context, _ string, @@ -768,7 +769,16 @@ func (c *IndexReaderWriter) GetShards( _ uint64, _ chunk.Predicate, ) ([]logproto.Shard, error) { - return nil, errors.New("unimplemented GetShards() on legacy index stores") + // should not be called for legacy indices at all, so just return a single shard covering everything + // could be improved by reading schema shards + return []logproto.Shard{ + logproto.Shard{ + Bounds: logproto.FPBounds{ + Min: 0, + Max: math.MaxUint64, + }, + }, + }, nil } // old index stores do not implement tsdb.ForSeries -- skip