-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unused path_prefix
config argument for pyroscope.scrape
#263
Comments
I can confirm this can be useful when running a custom path prefix. Pretty much likes Prometheus scraping path. |
CMIIW but the For example, Me thinks we can remove it :D |
@hainenber that's true, but it might be inconvenient to override for all types of profiles. |
While it's tedious to do the override but I think that gives a more granular control to the users. In addition, they don't need to check other options that would override theirs. Just simple Overall, I think it's a good DX and bless to folks designing this initially 😄 |
This issue has not had any activity in the past 30 days, so the |
Hi there 👋 On April 9, 2024, Grafana Labs announced Grafana Alloy, the spirital successor to Grafana Agent and the final form of Grafana Agent flow mode. As a result, Grafana Agent has been deprecated and will only be receiving bug and security fixes until its end-of-life around November 1, 2025. To make things easier for maintainers, we're in the process of migrating all issues tagged variant/flow to the Grafana Alloy repository to have a single home for tracking issues. This issue is likely something we'll want to address in both Grafana Alloy and Grafana Agent, so just because it's being moved doesn't mean we won't address the issue in Grafana Agent :) |
What's wrong?
The docs for
pyroscope.scrape
include a path_prefix argument, but the code forpyroscope.scrape
doesn't seem to do anything with it.We need to get a confirmation from the Pyroscope team that this config attribute is actually useful and that we should make it work. Otherwise we could just delete it.
Steps to reproduce
No need to reproduce.
System information
No response
Software version
No response
Configuration
No response
Logs
No response
The text was updated successfully, but these errors were encountered: