Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop button does not work #416

Closed
cjellick opened this issue Sep 4, 2024 · 8 comments
Closed

Stop button does not work #416

cjellick opened this issue Sep 4, 2024 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@cjellick
Copy link
Contributor

cjellick commented Sep 4, 2024

Stop button really really doesnt work well at all. Most of the time nothing happens when I click it. May or may not be happening specifically around tool calls

@cjellick cjellick added the bug Something isn't working label Sep 4, 2024
@sangee2004
Copy link

Is this relating to cancelling a chat response ? - #333

@cjellick
Copy link
Contributor Author

cjellick commented Sep 4, 2024

yes...but even clicking multiple times does nothing. i can click it a thousand times and the chat does not stop

@cjellick
Copy link
Contributor Author

cjellick commented Sep 7, 2024

was testing this out today and it seems like its kind of working now... the first click was stoppping. i had to click again to get the button back to send. but then, the message that was in progress is deleted. we should not delete the in progress message.

@tylerslaton
Copy link
Contributor

Yeah I also noticed the button seemed to be working fine, I'm doing a more in-depths dive into it right now to try and figure out how to improve. If you did have a case where the button does not work can you link it here?

As for the in progress message being deleted that sounds like a regression, it didn't do that before so I'll fix that too.

@tylerslaton
Copy link
Contributor

#495

@sangee2004
Copy link

Tested with latest build from 57e1a5c98

I had to click on stop twice for the message processing to stop actually.
And I see the response being printed twice in the chat window.
Once i quit the thread and revisit it , I dont see the message and the response that was stopped in the chat view.
This behavior seems very similar to #333 which was addressed earlier.

Screen.Recording.2024-09-11.at.11.39.58.AM.mov

@tylerslaton
Copy link
Contributor

#498

@sangee2004
Copy link

Tested with build - 809ed131

Able see messages being stopped when clicking on stop button once.

We still have the issue with the chat message and response (interrupted) being lost when the thread is revisted.

This issue is tracked in #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants