-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Die
behavior of initial / cloned sprite
#314
Comments
This was referenced Aug 20, 2024
Based on the comment here
@xushiwei To address compatibility concerns, I suggest:
|
This was referenced Sep 9, 2024
Closed
xushiwei
added a commit
that referenced
this issue
Sep 11, 2024
fix: Unify Die behavior of initial / cloned sprite #314
closed by #329 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In SPX, there are different implementations of the
Die
method for initial and cloned sprites:spx/sprite.go
Lines 483 to 494 in 3df776b
Ideally, there should be no noticeable differences for game developers, but this is not the case. For example, consider this sprite code:
After calling
die
, the loop continues, so"im alive"
keeps being printed.In contrast, for a cloned sprite:
After calling
die
, the loop stops, and"im alive"
is no longer printed.Game developers may perform more complex actions than just
println "im alive"
, potentially affecting overall game behavior. Therefore, it is crucial to unify the behavior ofdie
for both sprite types.Please check this out, @xushiwei @JiepengTan.
The text was updated successfully, but these errors were encountered: