fix: remove unnecessary warnings (#1256) #1257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jenxwa
changed the title
|
@jenxwa Thanks for cleaning up the demo app! Once you sign the CLA, we'll take a look. |
kikoso
requested changes
Oct 27, 2023
| findViewById<TextView>(R.id.textViewFirstLocation).text = "Location 1 is supported in StreetView: $response1" | ||
| findViewById<TextView>(R.id.textViewSecondLocation).text = "Location 2 is supported in StreetView: $response2" | ||
| findViewById<TextView>(R.id.textViewFirstLocation).text = getString(R.string.location_1_is_supported_in_streetview, response1) | ||
| findViewById<TextView>(R.id.textViewSecondLocation).text = getString(R.string.location_1_is_supported_in_streetview, response2) |
There was a problem hiding this comment.
These are two different strings, can you modify it?
| @@ -33,4 +33,6 @@ | |||
| <string name="button_radius">Radius</string> | |||
| <string name="button_gradient">Gradient</string> | |||
| <string name="button_opacity">Opacity</string> | |||
| <string name="location_1_is_supported_in_streetview">Location 1 is supported in StreetView: %1$s</string> | |||
| <string name="go">Go</string> | |||
|
@jenxwa , did you have the chance to check the comments and the CLA? Also, you need to follow the semantic PR convention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/Fixes #1256 🦕